Conversation
# Conflicts: # example/ios/OPSQLiteExample/AppDelegate.mm # example/ios/Podfile.lock # example/package.json # example/src/App.tsx # package.json # src/index.ts # yarn.lock Working promisify Working thread pool Working off-thread work Simplify data Run on Android Faster row creation Single struct that captures all state to correctly invalidate a module clean up Global call invoker ref Comments Migrate other functions
ospfranco
changed the title
| "dependencies": { | ||
| "react-native-safe-area-context": "^5.6.2" | ||
| } |
There was a problem hiding this comment.
@ospfranco Is this a mistake? I guess this should be only in the example no?
| @@ -1,17 +1,6 @@ | |||
| import { NativeModules } from 'react-native'; | |||
|
|
|||
| export { | |||
There was a problem hiding this comment.
Hey @ospfranco - this change is making TS unable to find the open fn etc with NodeNext module resolution. I think the same issue was originally fixed in #324. Are you open to reverting this change or was it causing issues elsewhere? Can patch on our side if not, no worries.
There was a problem hiding this comment.
that said, I think maybe "customConditions": ["source"], in our tsconfig can fix this
There was a problem hiding this comment.
ah, I didn't do this on purpose, this is just vscode/eslint or something else that automatically applies this change. If you can fix it on your end it would be better. This is something that has no priority for me.
There was a problem hiding this comment.
No worries, cheers for replying. Source didn't actually work when building but I think patching the d.ts file extensions into the imports in index.d.ts seems to do the trick. So more of an esm thing I guess (we're using op-sqlite inside a private npm package in a monorepo and all the packages are esm)
3 participants
Improves the speed to execute (and executAsync) JS object creation by close to 50% by using clever caching of names and removing one loop in JS
The code that handles JS promises has also been abstracted away and it's now miles easier to work with than before. It's a worthy addition because it opens the doors for more async code in the future.